[CMake] Don't update compile definitions for imported targets for MSCV #18766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makslevental
requested review from
stellaraccident,
ScottTodd and
IanWood1
and removed request for
benvanik
ScottTodd
added
infrastructure
ScottTodd
approved these changes
Oct 15, 2024
makslevental
added a commit
to nod-ai/iree-amd-aie
that referenced
this pull request
Oct 17, 2024
Get iree-org/iree#18766 which fixes a TODO. --------- Co-authored-by: yzhang93 <zhyuhang88@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one uses
-DIREE_BUILD_BUNDLED_LLVM=OFFthen targets for some libraries become imported/INTERFACEand CMake doesn't let you update theirtarget_compile_definitions. I.e., CMake errors out (not that it would work anyway). So just check and skip in that case.